Update object handlers #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
commented
Jun 3, 2022
|
Updating the PHP 5 part with PHP 7 docs doesn't make sense. The object section would likely need a from scratch rewrite for PHP 7, because things changed a lot in that area. |
|
@nikic I only noticed that this was in the PHP 5 section after. Should I copy the whole chapter to the 7 section and remove anything that's no longer accurate? Does it make sense to keep the two versions around? |
iluuu1994
force-pushed
the
update-object-handlers
branch
3 times, most recently
from
dce8477 to
243bdeb
Compare
iluuu1994
force-pushed
the
update-object-handlers
branch
from
243bdeb to
ef7414f
Compare
|
@nikic I copied the handler descriptions to the PHP 7/8 section and removed anything else that might be outdated. There were also some handlers missing which I added. Let me know if this looks good to you. Could you grant me edit access to this repository? I won't merge anything without creating an PR first except for minor non-technical things like typos. |
nikic
reviewed
Jun 9, 2022
| This is just the internal way of implementing the ``Countable::count`` method. The function returns a | ||
| ``zend_result`` and assigns the value to the ``zend_long *count`` pointer. | ||
|
|
||
| .. FIXME: Change return type of count_elements to zend_result to make it more obvious the count is not returned? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file only exists for the PHP 5 part of the book, I wonder if it's time to merge those and just make
mastermatch the currentmasterversion of php-src itself.